From 977b457d5ce7661e8b4680d5543ad4d31063dcf1 Mon Sep 17 00:00:00 2001
From: Alejandro Sirgo Rica <asirgo@soleta.eu>
Date: Tue, 25 Jun 2024 17:29:02 +0200
Subject: ogcp: add user permission mechanism

Add a new user permission system to control the allowed operations
accessible from each account.

Add a permission matrix editable through the user/add and user/edit
views. The permission matrix has client, center, room, folder, image
and repository as permission targets and add, update and delete as
permission types.

Restrict each view based on the user permissions, hide all actions
from not autheticated users.

permissions defined in the class UserForm.

Serialize each user permissions into ogcp.json as:
{
  ...
  "USERS" [
    {
      "USER": "admin"
      ...
      "PERMISSIONS": {
        "CLIENT": {
          "ADD": true,
          "UPDATE": true,
          "DELETE": true,
        },
        ... <- same structure for "CENTER", "ROOM", "FOLDER", "IMAGE"
               and "REPOSITORY"
      }
    },
    ...
  ],
  ...
}

Grant all the permissions to old user configuration to not disrupt their
workflow. The administrator will need to assign the permissions for each
user.

Ignore scope and permission restrictions for admin users.

Save permissions and scopes even if the user is admin to account for the
case of a temporal admin promotion without losing the previous
configuration.

Use template inheritance for add_user.html and edit_user.html to prevent
big code duplication with the new HTML code to render the permission
matrix.

Make user administration an admin only feature.

Define methods get_permission and target_is_disabled to improve readability
in template conditionals that disable features based on user permissions.
---
 ogcp/templates/images.html | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

(limited to 'ogcp/templates/images.html')

diff --git a/ogcp/templates/images.html b/ogcp/templates/images.html
index c439e52..00bb2e4 100644
--- a/ogcp/templates/images.html
+++ b/ogcp/templates/images.html
@@ -58,13 +58,15 @@
 {% endblock %}
 
 {% block commands %}
-  <input class="btn btn-light" type="submit" value="{{ _('Image details') }}"
-         form="imagesForm" formaction="{{ url_for('action_image_info') }}" formmethod="get">
-  <input class="btn btn-light" type="submit" value="{{ _('List images') }}"
-         form="imagesForm" formaction="{{ url_for('action_image_list') }}" formmethod="get">
-{% if current_user.admin %}
-  <input class="btn btn-light" type="submit" value="{{ _('Delete image') }}"
-         form="imagesForm" formaction="{{ url_for('action_image_delete') }}" formmethod="get">
+{% if current_user.is_authenticated %}
+    <input class="btn btn-light" type="submit" value="{{ _('Image details') }}"
+        form="imagesForm" formaction="{{ url_for('action_image_info') }}" formmethod="get">
+    <input class="btn btn-light" type="submit" value="{{ _('List images') }}"
+        form="imagesForm" formaction="{{ url_for('action_image_list') }}" formmethod="get">
+    {% if current_user.get_permission('IMAGE', 'DELETE') %}
+    <input class="btn btn-light" type="submit" value="{{ _('Delete image') }}"
+        form="imagesForm" formaction="{{ url_for('action_image_delete') }}" formmethod="get">
+    {% endif %}
 {% endif %}
   {% if btn_back %}
     <button class="btn btn-danger ml-3" type="button" id="backButton" onclick="history.back()">
-- 
cgit v1.2.3-18-g5258