summaryrefslogtreecommitdiffstats
path: root/src/ogRest.py
diff options
context:
space:
mode:
authorAlejandro Sirgo Rica <asirgo@soleta.eu>2024-03-18 14:17:12 +0100
committerlupoDharkael <izhe@hotmail.es>2024-03-21 10:29:57 +0100
commit2a4ce65a20b41a670b274cb473d46e62b4f3c913 (patch)
tree947c45ef966b226cbb980beabdc964184aa81a02 /src/ogRest.py
parent0cbf16461e05bc5f15d3436763667b1d34869826 (diff)
src: centralize error logging into send_internal_server_error
Use only the exception messages as the main resource for error messages. The previous error code had string duplication in the form of: logging.error('msg here') raise Exception('msg here') That approach also has the downside of having log duplication as it had the local logging.err() and a global logging.exception() inside send_internal_server_error capturing the exception message. The actual code only requires raising an exception with a proper error message. Improve exception messages to give more error context. Log every AssertionError as a backtrace. Use the 'raise Exception from e' syntax to modify the a previously raised exception 'e' into an exception with aditional context or different type. This also prevents the message that warns about newer exceptions being launch after an initial exception.
Diffstat (limited to 'src/ogRest.py')
-rw-r--r--src/ogRest.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/ogRest.py b/src/ogRest.py
index 7848c3d..47767b6 100644
--- a/src/ogRest.py
+++ b/src/ogRest.py
@@ -266,8 +266,10 @@ class ogRest():
raise ValueError('Mode not supported.')
def send_internal_server_error(self, client, exc=None):
- if exc:
- logging.exception('Unexpected error')
+ if isinstance(exc, AssertionError):
+ logging.exception(exc)
+ else:
+ logging.error(exc)
response = restResponse(ogResponses.INTERNAL_ERR, seq=client.seq)
client.send(response.get())
self.state = ThreadState.IDLE