summaryrefslogtreecommitdiffstats
path: root/src/live/ogOperations.py
Commit message (Collapse)AuthorAgeFilesLines
* utils: add postinstall.pyAlejandro Sirgo Rica2024-07-291-4/+5
| | | | | | | | | | | | | | | Replace ConfigureOs script by native calls to: - update BCD via hivex using bcd.py and winreg.py infrastructure. - restore efi bootloader restore_windows_efi_bootloader(). Call legacy scripts for remaining postinstall procedures to replace them incrementally. Define variable CONFIGUREOS_LEGACY_ENABLED as False by default. Run legacy configureOs when CONFIGUREOS_LEGACY_ENABLED = True. This serves as a auxiliar method to keep the restoration functional in case of problems with the new configure_os logic.
* utils: rename ogExtendFs to extend_filesystemAlejandro Sirgo Rica2024-07-291-1/+1
| | | | Use a more consistent name format for the ogExtendFs function.
* utils: fs: error out if mkfs failsOpenGnSys Support Team2024-07-291-2/+5
| | | | | | | | | | If formatting fails, log shows: mkfs.ntfs reports return code 1 for /dev/sda2 but ogclient reports success to the ogserver. Raise an exception so front-end gets an indication that formatting has failed.
* live: improve logging for file removal from cacheOpenGnSys Support Team2024-07-211-2/+8
| | | | Provide a bit more logging to make it easier to debug issues.
* live: add logging to indicate image file copy from sambaOpenGnSys Support Team2024-07-211-0/+2
| | | | For consistency with tiptorrent download.
* live: add checksum field to image/create responseOpenGnSys Support Team2024-07-151-4/+15
| | | | Report image checksum to ogserver through HTTP response.
* live: check permissions when trying to fetch file via unicastv1.3.2-12OpenGnSys Support Team2024-06-271-0/+4
| | | | check sufficient permissions and bail out in case of issues.
* live: revisit error log when failing to validate checksumOpenGnSys Support Team2024-06-271-1/+1
| | | | | | | | Add explicit check for .full.sum after downloading it. Rewrite errors log, one of them is misleading when checksum validation fails, it refers to missing .full.sum, but it could be a different reason.
* live: add restricted execution mode to shell/runAlejandro Sirgo Rica2024-06-251-4/+19
| | | | | | | | | | | | | | | Try to find the script to run for a shell/run request in /opt/opengnsys/shell/, restricted mode is enabled if the script is found. Excute the script without shell=True and executable=OG_SHELL in restricted mode. Restricted mode is a safer execution method as it only executes code manually defined by the administrator. Each script needs to define a shebang, this way more than just bash is supported.
* rest: add cmd field to POST /shell/runOpenGnSys Support Team2024-06-211-1/+1
| | | | | echo command that has been run for storage in ogserver, until GET /shell/output is invoked.
* rest: add retcode field to POST /shell/runOpenGnSys Support Team2024-06-211-1/+1
| | | | | | | | provide return code as result to ogserver. Update virtual mode driver to return dummy value, although this command is unimplemented, this seems to be broken due to possible TypeError when accessing result from caller.
* live: handle no cache in tiptorrent and unicast restorev1.3.2-11Alejandro Sirgo Rica2024-06-071-1/+4
| | | | | | Properly report the lack of cache partition when restoring an image using TIPTORRENT and UNICAST as methods. Abort any restore in case of no cache partition.
* utils: fix get_image_info regressionv1.3.2-10Alejandro Sirgo Rica2024-06-031-1/+0
| | | | | | | Fix image size, permissions and creation time. Improve error report related to these parameters now showing the exact cause of the problem if any occurred during the definition of image size, file permissions or image creation time values.
* live: revisit logging for checksum file creationv1.3.2-9OpenGnSys Support Team2024-05-311-4/+8
| | | | | Add logging before calculating checksum to provide a hint to user on what is going on while ogClient is still busy.
* src: cleanup ogGetImageInfoAlejandro Sirgo Rica2024-05-301-16/+1
| | | | | | Rename ogGetImageInfo to get_image_info. Move code from ogOperations.py to obtain image data into get_image_info.
* src: rename legacy.py into image.pyAlejandro Sirgo Rica2024-05-301-1/+1
| | | | | legacy.py contais mostly functions related to system images. Rename the file to better represent the contents in it.
* src: stop using hardcoded paths to cache image directoryAlejandro Sirgo Rica2024-05-301-5/+4
| | | | | | Use the constant OG_CACHE_IMAGE_PATH from cache.py to obtain the location of the directory where images are stored. This way the path can be changed from one single point.
* src: add cache info to the image/restore responseAlejandro Sirgo Rica2024-05-301-0/+8
| | | | | | | | | | | | | | | | Add a 'cache' field into the json payload the client sends to the server after a restore operation so the server can update the new cache contents. Resquest response structure: { ... 'cache': [ {'name': 'windows.img', 'size': 2432370213, checksum: '5d4dcc677bc19f40a647d0002f4ade90'}, {'name': 'linux.img', 'size': 243234534213, checksum: '3eb22f888f88a55ad954f55644e1192e'} ] ... }
* src: add POST cache/delete methodAlejandro Sirgo Rica2024-05-301-0/+40
| | | | | | | | | | | | | | | | | | | | Add API REST method to delete cache contents. Resquest payload structure: { 'images': ['windows.img', 'linux.img'] } The client will try to delete as many images in cache as available with names matching the list of filenames in the 'images' field. Resquest response structure: { 'cache': [ {'name': 'windows.img', 'size': 2432370213, checksum: '5d4dcc677bc19f40a647d0002f4ade90'}, {'name': 'linux.img', 'size': 243234534213, checksum: '3eb22f888f88a55ad954f55644e1192e'} ] }
* live: add cache contents to the /refresh payloadAlejandro Sirgo Rica2024-05-301-1/+41
| | | | | | | | | | | | | | | | | Add the list of images in the client's cache partition in the payload sent to the server. The information sent is a list of {image_name, img_size, checksum} elements where img_size is the size of the respective image in bytes. Resquest response structure: { ... 'cache': [ {'name': 'windows.img', 'size': 2432370213, checksum: '5d4dcc677bc19f40a647d0002f4ade90'}, {'name': 'linux.img', 'size': 243234534213, checksum: '3eb22f888f88a55ad954f55644e1192e'} ] ... }
* live: remove unused return value in image_restore()OpenGnSys Support Team2024-05-271-2/+1
| | | | Never used what configureOs() returns, remove it.
* live: incorrect reference to image checksum file in logsOpenGnSys Support Team2024-05-251-1/+1
| | | | checksum file name end by .img.full.sum, not .full.sum
* live: rename variable that stores json body in refresh()OpenGnSys Support Team2024-05-211-5/+5
| | | | Just a simple cleanup.
* utils: rename cache_probe() to get_cache_dev_path()OpenGnSys Support Team2024-05-091-2/+2
| | | | | | | | This method reports the /dev path to cache partition, rename it. Add explicit check if blkid is successful. And add logging to report that device path to cache is not found.
* live: report LINUX-SWAP instead of SWAPv1.3.2-8OpenGnSys Support Team2024-05-071-0/+3
| | | | | | | ogCP expects LINUX-SWAP to specify a swap filesystem. Add a similar workaround to the one that is done for VFAT for symmetry between inputs and outputs that circulate over the API.
* live: rewrite log in case tiptorrent client failsOpenGnSys Support Team2024-05-061-1/+1
| | | | | Specify that image file cannot be found in cache because tiptorrent has failed, otherwise it is confusing.
* live: restore partprobe before building filesystemOpenGnSys Support Team2024-05-061-1/+4
| | | | Otherwise mkfs silently fails because OS reports out-of-sync partition table.
* live: force flush to disk after partition table is writtenOpenGnSys Support Team2024-05-061-0/+1
|
* live: partprobe breaks with mounted partitionsOpenGnSys Support Team2024-05-061-2/+11
| | | | | | | | | | partprobe requires that all disk partitions are unmounted. partprobe needs to be called to report the OS that the partition table has changed, otherwise ogclient reports incorrect partition information. iterate over the partition list and mount cache after partprobe is called.
* live: umount all partitions before partition setupOpenGnSys Support Team2024-05-061-2/+3
| | | | | If new partition layout is specified, unmount cache and any other partition under /mnt.
* live: fix omited error report in tip_client_getAlejandro Sirgo Rica2024-05-061-7/+6
| | | | | | | tip_client_get raises the proper error exceptions but the except block in _restore_image_tiptorrent overwrites the reported error. Move the raise statements in _restore_image_tiptorrent outside of the except block.
* live: revisit logging for partition setup, image create and restoreOpenGnSys Support Team2024-04-231-7/+5
|
* live: improve exception handling in image_createAlejandro Sirgo Rica2024-04-031-27/+34
| | | | | | | | | | | | | | | | | Reduce the scope of the try except block that controls the case of deleting the image backup in case of error. Now it only covers the section of code after backup creation and up to image verification. Check when the Exception is an OgError to raise with added context. Prevent the deletion of the target image in case of error before the backup creation. Bundle the backup creation on its own try except block to give more feedback on a failed backup creation. Enables a better error management allowing unhandled exceptions to be reported properly.
* src: use explicit exception types in except Exception blocksAlejandro Sirgo Rica2024-04-031-3/+3
| | | | | | | | Capture only the relevant exception types in each except block. The capture of the Exception type means hiding information for unhandled error cases, even for syntax errors in the codebase. Using a more fine grained exception filtering improves error traceability.
* src: log backtrace in unhandled error casesAlejandro Sirgo Rica2024-04-031-24/+25
| | | | | | | | | | | | | | | | | | | Log an error message in known error cases and log a backtrace otherwise. Define a new error type OgError to be used in all the 'raise' blocks to define the error message to log. The exception propagates until it reaches send_internal_server_error() where the exception type is checked. If the type is OgError we log the exception message. Logs the backtrace for other types. The initial error implementation printed a backtrace everytime an error ocurred. The next iteration changed it to only print a backtrace in a very particular case but ended up omiting too much information such as syntax errors or unknown error context. The actual implementation only logs the cases we already cover in the codebase and logs a bracktrace in the others, enabling a better debugging experience.
* Revert "live: improve lzop and partclone error handling"OpenGnSys Support Team2024-04-011-46/+27
| | | | | | | | This reverts commit 57787dab5499a38915b5e2f702844553abd2ea2a. Read from stderr is blocking if no data is available, revert this patch since ogClient hangs indefinitely in lzop invocations due to races in process execution through Popen.
* live: display info logging when restoring image startsOpenGnSys Support Team2024-03-271-2/+2
| | | | instead of using debug level, this is very useful to track the process.
* live: use .ant image as main image after image creation errorAlejandro Sirgo Rica2024-03-271-0/+6
| | | | | | | Restore image file from .ant to original file name if new image creation fails. Remove new imagen and move the .ant image file in place of the original as previously an error meant a rename of the image file without a revert to keep the image available.
* utils: drop ogCopyEfiBootLoader scriptAlejandro Sirgo Rica2024-03-261-1/+1
| | | | | | | | Implement a Python equivalent of ogCopyEfiBootLoader as the function copy_efi_bootloader. This function copies the contents of the folder of the EFI loader in the ESP into a ogBoot folder at the root of the partition target of an image creation. copy_efi_bootloader is a Windows only functionality.
* live: improve lzop and partclone error handlingAlejandro Sirgo Rica2024-03-261-27/+47
| | | | | | | | | | | Control non 0 returncode of the lzop and partclone subprocess in image creation and restoration because this means that either lzop or partclone has failed. The implementation must cover cases such as not enough storage space and log errors into /tmp/command.log and the log file of the client handling the request. Check the returncode of lzop and partclone subprocesses and log the stderr of the process reporting non zero returncode.
* live: improve logging in image_createAlejandro Sirgo Rica2024-03-261-2/+2
| | | | | | Log the whole context of the error when an exception happens. The previous exception handling was hidding important information about the cause of the error.
* src: make exception messages more contextual and explicitAlejandro Sirgo Rica2024-03-211-1/+1
| | | | | | | Provide more information in exception messages as those are the source of the logging messages. Add information about paths, files or configuration related to the operation associated to the exception.
* src: change generic exception types to be more explicitAlejandro Sirgo Rica2024-03-211-3/+3
| | | | | | | | Replace exception types to be more explicit about the nature of the error. Improve the exception raising semantics by using the 'from' keyword, this wraps an older exception into a new one so it is still considered the same object.
* src: centralize error logging into send_internal_server_errorAlejandro Sirgo Rica2024-03-211-38/+21
| | | | | | | | | | | | | | | | | | | | Use only the exception messages as the main resource for error messages. The previous error code had string duplication in the form of: logging.error('msg here') raise Exception('msg here') That approach also has the downside of having log duplication as it had the local logging.err() and a global logging.exception() inside send_internal_server_error capturing the exception message. The actual code only requires raising an exception with a proper error message. Improve exception messages to give more error context. Log every AssertionError as a backtrace. Use the 'raise Exception from e' syntax to modify the a previously raised exception 'e' into an exception with aditional context or different type. This also prevents the message that warns about newer exceptions being launch after an initial exception.
* utils: implement BIOS boot for windowsAlejandro Sirgo Rica2024-03-211-26/+0
| | | | | | | | | | | | | | | | | | Create ogboot.me and ogboot.secondboot as empty files and ogboot.firstboot with the value "iniciado" in the root of the BIOS Windows system partition. The files must contain data for GRUB to be able to write content, therefore these are created containing 3072 null bytes. The Windows boot process is handled by the "pxe" profile. There the files ogboot.me, ogboot.firstboot and ogboot.secondboot are used as a state machine to chose between booting Windows and ogLive. The first Windows boot happens if ogboot.me and ogboot.firstboot are identical, then "iniciado" is written in ogboot.firstboot. We skip this stage as we create ogboot.firstboot with 'iniciado'. The second Windows boot occurs if ogboot.me and ogboot.secondboot are boot identical, then "iniciado" is written in ogboot.secondboot. After the Windows boot ogLive is booted.
* live: check if cache partition is available before calling tiptorrentAlejandro Sirgo Rica2024-03-211-0/+4
| | | | | | The image restore command must check if the cache partition is available. Otherwise if the user forgets to create the cache tiptorrent fails.
* utils: move all boot from OS functionality into boot.pyAlejandro Sirgo Rica2024-03-081-19/+25
| | | | | | | | This change is a preparative for reimplementing the BIOS boot in order to deprecate the legacy script. All the codepaths to boot systems located at a partition are now called from the boot_os_at function enabling an easier structure for the incoming code.
* utils: improve uefi detection mechanismAlejandro Sirgo Rica2024-03-081-1/+1
| | | | | | | Checking the existence /sys/firmware/efi as it might appear sometimes in BIOS installs if the BIOS configuration is not proper. Checking for the EFI partition is the safest method to veryfy the install type.
* live: drop IniciarSesion script when uefi bootingJose M. Guisado2024-03-041-0/+10
| | | | | | | | Replace IniciarSesion script in favor of native Python code when booting a UEFI system. This applies when running the "session" command. WIP: Only UEFI boots Windows systems. Raise NotImplementedError exception trying to boot a Linux system using UEFI.
* live: improve logging with setup commandOpenGnSys Support Team2024-02-221-2/+10
| | | | | | Improve logging when setting up partition, provide more hints on progress. Fail in case partition layout is not supported.