| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
| |
Never used what configureOs() returns, remove it.
|
| |
|
|
| |
checksum file name end by .img.full.sum, not .full.sum
|
| |
|
|
| |
Just a simple cleanup.
|
| |
|
|
| |
Add 0xef partition type for EFI in MBR.
|
| |
|
|
| |
Remove reference to external website in code.
|
| |
|
|
|
|
|
|
| |
This method reports the /dev path to cache partition, rename it.
Add explicit check if blkid is successful.
And add logging to report that device path to cache is not found.
|
| |
|
|
|
| |
Add a check for potential permission or IO errors during the
creation of the image checksum.
|
| |
|
|
|
|
| |
Add exception checks to the os.mkdir operation and log the error
found. The previous implementation was too optimistic and only
handled mount related errors.
|
| |
|
|
|
| |
The json library was a dependency during the development of the
boot OS functions and it is no longer needed in that file.
|
| |
|
|
|
| |
Call the error() logging function from the logging object instead
of the non existent log variable previously referenced.
|
| |
|
|
|
|
| |
Report mkfs failure for every partition. This does not raise an
exception as that would skip partprobe operations and the mkfs
operations in the next potentially well formated partitions.
|
| |
|
|
|
|
|
| |
ogCP expects LINUX-SWAP to specify a swap filesystem.
Add a similar workaround to the one that is done for VFAT for symmetry between
inputs and outputs that circulate over the API.
|
| |
|
|
|
| |
Specify that image file cannot be found in cache because tiptorrent has failed,
otherwise it is confusing.
|
| |
|
|
| |
Otherwise mkfs silently fails because OS reports out-of-sync partition table.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
partprobe requires that all disk partitions are unmounted.
partprobe needs to be called to report the OS that the partition table
has changed, otherwise ogclient reports incorrect partition information.
iterate over the partition list and mount cache after partprobe is
called.
|
| |
|
|
|
| |
If new partition layout is specified, unmount cache and any other partition
under /mnt.
|
| |
|
|
|
|
|
| |
tip_client_get raises the proper error exceptions but the except
block in _restore_image_tiptorrent overwrites the reported error.
Move the raise statements in _restore_image_tiptorrent outside
of the except block.
|
| |
|
|
|
|
| |
Use "Microsoft basic data partition" to store FAT32 in case of GPT partition
scheme and 0xB according in case of MBR partition scheme according to
documentation.
|
| | |
|
| |
|
|
| |
Display if checksum validation is correct or not.
|
| | |
|
| |
|
|
| |
fat does not support this operation, skip it
|
| |
|
|
| |
ret is set but never used in this method
|
| |
|
|
| |
not really a warning, report an error instead
|
| |
|
|
|
|
|
|
| |
otherwise error path uses uninitialized variable
File "/opt/opengnsys/ogClient/src/utils/fs.py", line 112, in ogReduceFs
return ret
UnboundLocalError: local variable 'ret' referenced before assignment
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce the scope of the try except block that controls the case
of deleting the image backup in case of error. Now it only covers
the section of code after backup creation and up to image
verification. Check when the Exception is an OgError to raise
with added context.
Prevent the deletion of the target image in case of error before
the backup creation.
Bundle the backup creation on its own try except block to give
more feedback on a failed backup creation.
Enables a better error management allowing unhandled
exceptions to be reported properly.
|
| |
|
|
|
|
|
|
| |
Capture only the relevant exception types in each except block.
The capture of the Exception type means hiding information for
unhandled error cases, even for syntax errors in the codebase.
Using a more fine grained exception filtering improves error
traceability.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Log an error message in known error cases and log a backtrace
otherwise.
Define a new error type OgError to be used in all the 'raise'
blocks to define the error message to log. The exception
propagates until it reaches send_internal_server_error() where
the exception type is checked. If the type is OgError we log
the exception message. Logs the backtrace for other types.
The initial error implementation printed a backtrace everytime
an error ocurred. The next iteration changed it to only print
a backtrace in a very particular case but ended up omiting too
much information such as syntax errors or unknown error context.
The actual implementation only logs the cases we already cover in
the codebase and logs a bracktrace in the others, enabling a
better debugging experience.
|
| |
|
|
| |
Replace incorrect copyright header in qmp.py file.
|
| |
|
|
|
|
| |
Refine 97647c32aa2c utils: add enforce_gpt argument to get_efi_partition()
to provide more explicit error when trying to boot Windows UEFI from DOS
partition.
|
| |
|
|
|
|
|
|
| |
This reverts commit 57787dab5499a38915b5e2f702844553abd2ea2a.
Read from stderr is blocking if no data is available, revert this patch since
ogClient hangs indefinitely in lzop invocations due to races in process
execution through Popen.
|
| |
|
|
|
|
|
|
| |
Replace unexistent mountpoint variable to report a failed
mount operation before an OS probe from a partition.
Improve the semantics of the error message replacing 'at' with
'into'.
Remove the period at the end of the log message.
|
| |
|
|
| |
instead of using debug level, this is very useful to track the process.
|
| |
|
|
|
|
|
| |
Restore image file from .ant to original file name if new image
creation fails. Remove new imagen and move the .ant image file in
place of the original as previously an error meant a rename of the
image file without a revert to keep the image available.
|
| |
|
|
|
|
| |
Make init_cache() use the actual cache mountpoint returned by the
function mount_cache() for the creation of the cache directories
instead of a hardcoded path.
|
| |
|
|
|
|
| |
Remove return statement the program won't reach and simplify the
return logic with a return from an if and a fallback return
statement.
|
| |
|
|
|
|
|
|
| |
Implement a Python equivalent of ogCopyEfiBootLoader as the
function copy_efi_bootloader. This function copies the contents of
the folder of the EFI loader in the ESP into a ogBoot folder at
the root of the partition target of an image creation.
copy_efi_bootloader is a Windows only functionality.
|
| |
|
|
|
|
|
|
|
|
|
| |
Control non 0 returncode of the lzop and partclone subprocess
in image creation and restoration because this means that either
lzop or partclone has failed.
The implementation must cover cases such as not enough storage
space and log errors into /tmp/command.log and the log file of
the client handling the request.
Check the returncode of lzop and partclone subprocesses and
log the stderr of the process reporting non zero returncode.
|
| |
|
|
|
|
| |
Log the whole context of the error when an exception happens.
The previous exception handling was hidding important information
about the cause of the error.
|
| |
|
|
|
|
|
| |
The Windows bootloader only supports a UEFI boot from a GPT
partition. Set enforce_gpt to True in every codepath related to
Windows. When enforce_gpt is set to True get_efi_partition()
raises an exception when an MBR partition scheme is detected.
|
| |
|
|
|
|
|
|
|
|
|
| |
Make is_uefi_supported() only check for /sys/firmware/efi as
get_efi_partition() will detect a missing ESP or an invalid
partition scheme. Stop using get_efi_partition() inside
is_uefi_supported() as the former is eventually called in every
UEFI related code.
UEFI supports both MBR and GPT as partition schemes and this is
a required change to handle the particular case of Windows not
being able to boot UEFI from a MBR partition scheme.
|
| |
|
|
|
|
|
| |
Provide more information in exception messages as those are the
source of the logging messages. Add information about paths, files
or configuration related to the operation associated to the
exception.
|
| |
|
|
|
|
|
|
| |
Replace exception types to be more explicit about the nature of
the error.
Improve the exception raising semantics by using the 'from' keyword,
this wraps an older exception into a new one so it is still considered
the same object.
|
| |
|
|
|
| |
Add the string prefix f'' to string instances formated as f-string
but not properly constructed to expand the inline variables.
|
| |
|
|
|
| |
Raise exception from subprocess.run() calls as previous code is
trying to capture these exceptions to handle de errors.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use only the exception messages as the main resource for error
messages.
The previous error code had string duplication in the form of:
logging.error('msg here')
raise Exception('msg here')
That approach also has the downside of having log duplication as
it had the local logging.err() and a global logging.exception()
inside send_internal_server_error capturing the exception message.
The actual code only requires raising an exception with a proper
error message.
Improve exception messages to give more error context.
Log every AssertionError as a backtrace.
Use the 'raise Exception from e' syntax to modify the a previously
raised exception 'e' into an exception with aditional context or
different type. This also prevents the message that warns about
newer exceptions being launch after an initial exception.
|
| |
|
|
|
|
|
|
|
| |
The main function must be able to handle the login of critical
error in the main ogClient class instance. Add a try except block
to the ogCLient run logic and move the relevant error logs into
the except block.
Delegate the error messages to the exception message. This is the
first step towards error message deduplication.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create ogboot.me and ogboot.secondboot as empty files and
ogboot.firstboot with the value "iniciado" in the root of
the BIOS Windows system partition.
The files must contain data for GRUB to be able to write content,
therefore these are created containing 3072 null bytes.
The Windows boot process is handled by the "pxe" profile.
There the files ogboot.me, ogboot.firstboot and ogboot.secondboot
are used as a state machine to chose between booting Windows and
ogLive.
The first Windows boot happens if ogboot.me and ogboot.firstboot
are identical, then "iniciado" is written in ogboot.firstboot.
We skip this stage as we create ogboot.firstboot with 'iniciado'.
The second Windows boot occurs if ogboot.me and ogboot.secondboot
are boot identical, then "iniciado" is written in ogboot.secondboot.
After the Windows boot ogLive is booted.
|
| |
|
|
|
| |
Control the possibility of a bad disk index. Handle the checks in
a similar fashion to the get_efi_partition function.
|
