From 72d8943576610395582f95b170730bae4adf2287 Mon Sep 17 00:00:00 2001 From: Alejandro Sirgo Rica Date: Mon, 27 May 2024 10:27:57 +0200 Subject: virtual: handle copy error in image restore Add a proper error report for the shutil.copy operation in image_restore() instead of silently returning. --- src/virtual/ogOperations.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/virtual/ogOperations.py b/src/virtual/ogOperations.py index 2b69fd1..d40170e 100644 --- a/src/virtual/ogOperations.py +++ b/src/virtual/ogOperations.py @@ -449,9 +449,10 @@ class OgVirtualOperations: subprocess.run([cmd], shell=True, check=True) try: - shutil.copy(f'{self.OG_IMAGES_PATH}/{name}', drive_path) - except: - return None + copy_src = f'{self.OG_IMAGES_PATH}/{name}' + shutil.copy(copy_src, drive_path) + except Exception as e: + raise OgError(f'Error trying to copy {copy_src} into {drive_path}: {e}') from e subprocess.run([f'umount {self.OG_IMAGES_PATH}'], shell=True) self.refresh(ogRest) -- cgit v1.2.3-18-g5258