From dfde363aa63ad3e7967da49f4ab599399b89e7f8 Mon Sep 17 00:00:00 2001 From: Alejandro Sirgo Rica Date: Tue, 2 Apr 2024 12:51:34 +0200 Subject: src: log backtrace in unhandled error cases Log an error message in known error cases and log a backtrace otherwise. Define a new error type OgError to be used in all the 'raise' blocks to define the error message to log. The exception propagates until it reaches send_internal_server_error() where the exception type is checked. If the type is OgError we log the exception message. Logs the backtrace for other types. The initial error implementation printed a backtrace everytime an error ocurred. The next iteration changed it to only print a backtrace in a very particular case but ended up omiting too much information such as syntax errors or unknown error context. The actual implementation only logs the cases we already cover in the codebase and logs a bracktrace in the others, enabling a better debugging experience. --- src/utils/bios.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/utils/bios.py') diff --git a/src/utils/bios.py b/src/utils/bios.py index 1c16633..9c62b38 100644 --- a/src/utils/bios.py +++ b/src/utils/bios.py @@ -8,6 +8,7 @@ import logging import os +from src.log import OgError def get_grub_boot_params(mountpoint, device): @@ -35,7 +36,7 @@ def get_vmlinuz_path(mountpoint): target_file = file if not target_file: - raise FileNotFoundError(f'vmlinuz not found in {initrd_dir}') + raise OgError(f'vmlinuz not found in {initrd_dir}') return os.path.join(linuz_dir, target_file) @@ -48,6 +49,6 @@ def get_initrd_path(mountpoint): target_file = file if not target_file: - raise FileNotFoundError(f'initrd not found in {initrd_dir}') + raise OgError(f'initrd not found in {initrd_dir}') return os.path.join(initrd_dir, target_file) -- cgit v1.2.3-18-g5258