From 44250d033462666b9983c8d9b8e1c6cda5236ceb Mon Sep 17 00:00:00 2001 From: OpenGnSys Support Team Date: Wed, 14 Feb 2024 17:30:16 +0100 Subject: live: remove mbuffer leftover in image restore command Remove mbuffer, this is never used. mbuffer has been never been used since ogClient supports native image restore. Originally this was used like this: partclone [...] | mbuffer -q -M 40M | lzop [...] supposely to speed up partclone in case the device where the read happens is slowier than the device that is used for writes. See mbuffer(1) manpage examples. In any case, this needs benchmarking to really make sure this is helping. Remove it until that ever happens. --- src/live/ogOperations.py | 1 - 1 file changed, 1 deletion(-) (limited to 'src') diff --git a/src/live/ogOperations.py b/src/live/ogOperations.py index 93836f7..05e6c8e 100644 --- a/src/live/ogOperations.py +++ b/src/live/ogOperations.py @@ -178,7 +178,6 @@ class OgLiveOperations: logging.debug(f'This process can take some time, please *DO NOT SHUT DOWN OR REBOOT* this client') cmd_lzop = shlex.split(f'lzop -dc {image_path}') cmd_pc = shlex.split(f'partclone.restore -d0 -C -I -o {devpath}') - cmd_mbuffer = shlex.split('mbuffer -q -m 40M') if shutil.which('mbuffer') else None if not os.path.exists(image_path): logging.error('f{image_path} does not exist, exiting.') -- cgit v1.2.3-18-g5258