summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoberto Hueso Gómez <rhueso@soleta.eu>2019-11-05 11:40:30 +0100
committerOpenGnSys Support Team <soporte-og@soleta.eu>2019-11-06 11:26:45 +0100
commit1a1ecf7791e06c3c7fb03cbb9e401bbcecf427a3 (patch)
tree02ec46310146ee10ad83b4af80a435e7adf41d41
parent7803e13adf1f7bab6c1004a659942a55d1ee085c (diff)
#915 Validate POST /software REST API parameters
This patch ensures that all required parameters are sent in the request.
-rw-r--r--sources/ogAdmServer.cpp13
1 files changed, 11 insertions, 2 deletions
diff --git a/sources/ogAdmServer.cpp b/sources/ogAdmServer.cpp
index db95298..553cccc 100644
--- a/sources/ogAdmServer.cpp
+++ b/sources/ogAdmServer.cpp
@@ -3975,15 +3975,24 @@ static int og_cmd_software(json_t *element, struct og_msg_params *params)
json_object_foreach(element, key, value) {
if (!strcmp(key, "clients"))
err = og_json_parse_clients(value, params);
- else if (!strcmp(key, "disk"))
+ else if (!strcmp(key, "disk")) {
err = og_json_parse_string(value, &params->disk);
- else if (!strcmp(key, "partition"))
+ params->flags |= OG_REST_PARAM_DISK;
+ }
+ else if (!strcmp(key, "partition")) {
err = og_json_parse_string(value, &params->partition);
+ params->flags |= OG_REST_PARAM_PARTITION;
+ }
if (err < 0)
break;
}
+ if (!og_msg_params_validate(params, OG_REST_PARAM_ADDR |
+ OG_REST_PARAM_DISK |
+ OG_REST_PARAM_PARTITION))
+ return -1;
+
len = snprintf(buf, sizeof(buf),
"nfn=InventarioSoftware\rdsk=%s\rpar=%s\r",
params->disk, params->partition);