diff options
| author | Roberto Hueso Gómez <rhueso@soleta.eu> | 2019-11-13 12:21:42 +0100 |
|---|---|---|
| committer | OpenGnSys Support Team <soporte-og@soleta.eu> | 2019-11-13 14:15:43 +0100 |
| commit | 6c91d147c1c31a7fa78f2721e1c963500a49084d (patch) | |
| tree | 6aee9716c6ec7e4d911833d44000a049a3280218 | |
| parent | ee2e16ac96b259e1fce7029301b3da2b157ecd4c (diff) | |
#915 Rename POST /image/setup for /setup in REST API
This patch renames the setup command to avoid semantic confusion.
| -rw-r--r-- | sources/ogAdmServer.cpp | 6 | ||||
| -rwxr-xr-x | tests/run-tests.sh | 2 | ||||
| -rw-r--r-- | tests/units/test_0018_post_setup.py (renamed from tests/units/test_0018_post_image_setup.py) | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/sources/ogAdmServer.cpp b/sources/ogAdmServer.cpp index 9f4c57a..2a66385 100644 --- a/sources/ogAdmServer.cpp +++ b/sources/ogAdmServer.cpp @@ -4228,7 +4228,7 @@ static int og_cmd_restore_image(json_t *element, struct og_msg_params *params) return 0; } -static int og_cmd_setup_image(json_t *element, struct og_msg_params *params) +static int og_cmd_setup(json_t *element, struct og_msg_params *params) { char buf[4096] = {}; int err = 0, len; @@ -4933,7 +4933,7 @@ static int og_client_state_process_payload_rest(struct og_client *cli) return og_client_bad_request(cli); } err = og_cmd_restore_image(root, ¶ms); - } else if (!strncmp(cmd, "image/setup", strlen("image/setup"))) { + } else if (!strncmp(cmd, "setup", strlen("setup"))) { if (method != OG_METHOD_POST) return og_client_method_not_found(cli); @@ -4941,7 +4941,7 @@ static int og_client_state_process_payload_rest(struct og_client *cli) syslog(LOG_ERR, "command create with no payload\n"); return og_client_bad_request(cli); } - err = og_cmd_setup_image(root, ¶ms); + err = og_cmd_setup(root, ¶ms); } else if (!strncmp(cmd, "run/schedule", strlen("run/schedule"))) { if (method != OG_METHOD_POST) return og_client_method_not_found(cli); diff --git a/tests/run-tests.sh b/tests/run-tests.sh index 519366f..893e026 100755 --- a/tests/run-tests.sh +++ b/tests/run-tests.sh @@ -14,7 +14,7 @@ curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/hardware -d @pos curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/software -d @post_clients.json curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/image/create -d @create_image.json curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/image/restore -d @restore_image.json -curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/image/setup -d @setup_image.json +curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/setup -d @setup_image.json curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/image/create/basic -d @create_basic_image.json curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/image/create/incremental -d @create_incremental_image.json curl -X POST -H "Authorization: $API_KEY" http://127.0.0.1:8888/image/restore/basic -d @restore_basic_image.json diff --git a/tests/units/test_0018_post_image_setup.py b/tests/units/test_0018_post_setup.py index 3876e23..9d26b85 100644 --- a/tests/units/test_0018_post_image_setup.py +++ b/tests/units/test_0018_post_setup.py @@ -1,10 +1,10 @@ import requests import unittest -class TestPostSetupImageMethods(unittest.TestCase): +class TestPostSetupMethods(unittest.TestCase): def setUp(self): - self.url = 'http://localhost:8888/image/setup' + self.url = 'http://localhost:8888/setup' self.headers = {'Authorization' : '07b3bfe728954619b58f0107ad73acc1'} self.json = { 'clients' : [ '192.168.2.1', '192.168.2.2' ], 'disk' : '1', |