summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOpenGnSys Support Team <soporte-og@soleta.eu>2020-03-26 10:45:51 +0100
committerOpenGnSys Support Team <soporte-og@soleta.eu>2020-03-26 11:45:19 +0100
commit26736edcd084702d9c39a359ace457b3631ddfbc (patch)
tree3b975a270300ec5fbeca801c8d513bbcf8b36e69
parent4f850d5acce0a9fd7e345e8752d45204d61937e2 (diff)
#941 Missing error in actualizaSoftware() and memleak in result
This patch fixes e052fdceec013 that adds a missing error in case the insertion fails. This also releases the result in case the entry exists.
-rw-r--r--sources/ogAdmServer.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/sources/ogAdmServer.c b/sources/ogAdmServer.c
index d4a04d2..322d2f2 100644
--- a/sources/ogAdmServer.c
+++ b/sources/ogAdmServer.c
@@ -2372,16 +2372,17 @@ bool actualizaSoftware(struct og_dbi *dbi, char *sft, char *par,char *ido,
" VALUES(2,'%s',%s,0)", tbSoftware[i], idc);
if (!result) { // Error al insertar
dbi_conn_error(dbi->conn, &msglog);
- og_info((char *)msglog);
+ syslog(LOG_ERR, "failed to query database (%s:%d) %s\n",
+ __func__, __LINE__, msglog);
return false;
}
- dbi_result_free(result);
// Recupera el identificador del software
tbidsoftware[i] = dbi_conn_sequence_last(dbi->conn, NULL);
} else {
tbidsoftware[i] = dbi_result_get_uint(result, "idsoftware");
}
+ dbi_result_free(result);
}
// Ordena tabla de identificadores para cosultar si existe un pefil con esas especificaciones