diff options
| author | Jose M. Guisado <jguisado@soleta.eu> | 2023-09-28 10:01:09 +0200 |
|---|---|---|
| committer | Jose M. Guisado <jguisado@soleta.eu> | 2023-09-28 10:07:07 +0200 |
| commit | 35a3b0a1a3230e465b3a434603cd6608b3350121 (patch) | |
| tree | c0504931071a35f2f4bbbbb9f3356e719116a39f /src/schema.c | |
| parent | e080fd5526949a5615ae391ea9dda8b70c95f345 (diff) | |
schema: fix bug when og_dbi_open cannot open a connection
When og_dbi_open cannot open a connection during schema update, then
ogServer crashes.
og_dbi_open returns NULL when it cannot open a DB connection.
Do not use dbi variable if og_dbi_open is unable to open a DB
connection.
Add syslog message when database schema couldn't be updated.
Diffstat (limited to 'src/schema.c')
| -rw-r--r-- | src/schema.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/schema.c b/src/schema.c index 56d52ba..d31046e 100644 --- a/src/schema.c +++ b/src/schema.c @@ -255,13 +255,11 @@ int og_dbi_schema_update(void) { int version, i, err; struct og_dbi *dbi; - const char *msglog; dbi = og_dbi_open(&ogconfig.db); if (!dbi) { - dbi_conn_error(dbi->conn, &msglog); - syslog(LOG_ERR, "failed to query database (%s:%d) %s\n", - __func__, __LINE__, msglog); + syslog(LOG_ERR, "cannot open a database connection (%s:%d)\n", + __func__, __LINE__); return -1; } |