summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* #915: Reply 413 status code when no payload is too largeJavier Sánchez Parra2020-04-061-0/+11
| | | | | | | | | | | | | | If the payload is too long, then the API returns a 413 status code (following RFC 7231) instead of the resetting the communication without replying. This way it should be more clear when this problem is happening. The other commit I did related to the issue of the payload size (1d9d93c) said that ogAdmServer do not log anything when it receives a payload of a bigger size than supported, this is false. ogAdmServer prints the next message to the syslog when this happens: ogAdmServer[6824]: client request from 127.0.0.1:43552 is too long
* #915 Increase request max lengthJavier Sánchez Parra2020-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Trying to send a WakeOnLan command to 150 clients I noticed that the ogAdmClient closed (RST) the communication with the WebConsole without answering or logging anything. The Webconsole logged: php: error occured during curl exec. Additioanl info: Array php: ( php: [url] => http://127.0.0.1:8888/wol php: [content_type] => php: [http_code] => 0 php: [header_size] => 0 php: [request_size] => 199 php: [filetime] => -1 php: [ssl_verify_result] => 0 php: [redirect_count] => 0 php: [total_time] => 1.003122 php: [namelookup_time] => 4.9E-5 php: [connect_time] => 0.000273 php: [pretransfer_time] => 0.00035 php: [size_upload] => 7007 php: [size_download] => 0 php: [speed_download] => 0 php: [speed_upload] => 6986 php: [download_content_length] => -1 php: [upload_content_length] => 7007 php: [starttransfer_time] => 1.001793 php: [redirect_time] => 0 php: [redirect_url] => php: [primary_ip] => 127.0.0.1 php: [certinfo] => Array php: ( php: ) php: php: [primary_port] => 8888 php: [local_ip] => 127.0.0.1 php: [local_port] => 43016 php: [http_version] => 0 php: [protocol] => 1 php: [ssl_verifyresult] => 0 php: [scheme] => HTTP php: ) This happened because request max length is set to 4096 bytes and my request had a size of 7075 bytes. So, the max length was exceeded. This commit increase the max length from 4096 to 16384. This way the ogAdmServer supports larger request messages.
* #941 memleak in actualizaConfiguracionOpenGnSys Support Team2020-03-311-2/+6
| | | | Missing dbi_result_free(), use syslog() for logging.
* #941 Missing error in actualizaSoftware() and memleak in resultOpenGnSys Support Team2020-03-261-2/+3
| | | | | | This patch fixes e052fdceec013 that adds a missing error in case the insertion fails. This also releases the result in case the entry exists.
* #580 double free in checkDato()OpenGnSys Support Team2020-03-241-2/+0
| | | | This is fixing e052fdceec013 that releases the libdbi result twice.
* #915 remove dead code in ogAdmServerOpenGnSys Support Team2020-03-071-27/+0
| | | | These have been replaced by the new REST API.
* #580 Fix uninitialized variables in ogAdmServerRoberto Hueso Gómez2020-03-071-1/+6
| | | | This patch ensures that some variables are initialized before using them.
* #967 rename .cpp to .cOpenGnSys Support Team2020-03-053-5/+1
| | | | This actually is C code, use the gcc compiler instead.
* #967 Replace remaining C++ codeOpenGnSys Support Team2020-03-051-4/+4
|
* #941 use dbi layer from envioProgramacionOpenGnSys Support Team2020-03-043-40/+31
|
* #941 use dbi layer from actualizaHardwareOpenGnSys Support Team2020-03-042-136/+104
|
* #941 use dbi layer from RESPUESTA_CrearSoftIncrementalOpenGnSys Support Team2020-03-041-23/+26
|
* #941 use dbi layer from actualizaCreacionImagen()OpenGnSys Support Team2020-03-042-35/+35
|
* #941 use dbi layer from actualizaConfiguracion()OpenGnSys Support Team2020-03-042-250/+163
|
* #941 use dbi layer from procesoInclusionCliente()OpenGnSys Support Team2020-03-041-46/+36
|
* #941 use dbi layer from respuestaEstandar()OpenGnSys Support Team2020-03-041-73/+131
| | | | | | | And update all callers. Some of the db.Open() calls cannot be removed yet, since there are still more function dependencies that need to be converted too.
* #941 Consolidate CrearSoftIncremental, RestaurarImagenBasica, ↵OpenGnSys Support Team2020-03-041-111/+5
| | | | | | RestaurarSoftIncremental, Configurar and EjecutarScript These functions are identical, remove duplicated code.
* #941 Consolidate RESPUESTA_Reiniciar, RESPUESTA_IniciarSesion and ↵OpenGnSys Support Team2020-03-041-94/+2
| | | | | | RESPUESTA_Apagar They are identical, remove duplicated code.
* #941 Consolidate RESPUESTA_Configurar and RESPUESTA_EjecutarScriptOpenGnSys Support Team2020-03-041-56/+8
| | | | These function are almost identical, remove duplicated code.
* #941 use dbi layer from buscaComandos()OpenGnSys Support Team2020-03-041-38/+40
|
* #941 use dbi layer from AutoexecCliente()OpenGnSys Support Team2020-03-042-31/+25
|
* #941 use dbi layer from procesoInclusionClienteWinLnx()OpenGnSys Support Team2020-03-041-40/+34
|
* #941 add basic database-independent abstraction (dbi)OpenGnSys Support Team2020-03-043-2/+60
| | | | Add basic infrastructure to support for the independent database layer.
* #924 Fix that only the commands without session were checkedJavier Sánchez Parra2019-11-251-0/+5
| | | | | | | | | | | Irina reports that the bug fixed in 78a97c5 happens again when you run a command with a session (queue of actions). The bug was introduced in 78a97c5, the goal of the commit was to change the behaviour of respuestaEstandar to always check the result of a command, whether it has a session or not. But, instead of this behaviour, the commit changes respuestaEstandar to only check the commands without session.
* #839: Always update the partition types when obtaining the computer ↵Ramón M. Gómez2019-11-211-1/+2
| | | | configuration.
* #915 Test malformed payload for POST commandsRoberto Hueso Gómez2019-11-1416-0/+109
| | | | | | | | | | | | | | | | | | | | | | | | This patch includes tests for the remaining REST API commands: POST /shell/output POST /session POST /poweroff POST /reboot POST /stop POST /refresh POST /hardware POST /software POST /image/create POST /image/restore POST /setup POST /image/create/basic POST /image/create/incremental POST /image/restore/basic POST /image/restore/incremental POST /run/schedule This test covers requests that are missing one of the parameters in its payload.
* #915 Test malformed payload for POST /shell/runRoberto Hueso Gómez2019-11-131-0/+9
| | | | | This test covers requests that do not contain 1 of the parameters in their payloads.
* #915 Test malformed payload for POST /wolRoberto Hueso Gómez2019-11-131-0/+9
| | | | | This test covers requests that do not contain 1 of the parameters in their payloads.
* #915 Test malformed payload for POST /clientsRoberto Hueso Gómez2019-11-131-0/+4
| | | | | This test covers requests that do not contain 1 of the parameters in their payloads.
* #915 Return HTTP 400 error code in og_client_state_process_payload_restRoberto Hueso Gómez2019-11-131-1/+1
| | | | | This patch meets RFC 7235 and returns an HTTP 400 error code when ogAdmServer recieves a wrong request.
* #915 Extend REST API POST no payload tests to all remaining tests.Roberto Hueso Gómez2019-11-1311-0/+44
| | | | | | | | | | | | | | | | | This patch extends tests for requests without any payload in the following REST API POST functions: - /clients - /wol - /shell/run - /shell/output - /session - /poweroff - /reboot - /stop - /refresh - /hardware - /software
* #915 Rename POST /image/setup for /setup in REST APIRoberto Hueso Gómez2019-11-133-6/+6
| | | | This patch renames the setup command to avoid semantic confusion.
* #915 Adapt POST /shell/run test to the 'echo' parameterRoberto Hueso Gómez2019-11-121-1/+3
|
* #915 Add 'echo' parameter to POST /shell/runRoberto Hueso Gómez2019-11-121-4/+31
| | | | 'echo' parameter makes possible for users to request the console output.
* #915 Fix og_json_parse_clients flags for empty arraysRoberto Hueso Gómez2019-11-121-2/+2
| | | | | This patch prevents the flag OG_REST_PARAM_ADDR to be activated when the array is empty.
* #915 Validate POST /run/schedule REST API parametersRoberto Hueso Gómez2019-11-121-0/+3
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /image/restore/incremental REST API parametersRoberto Hueso Gómez2019-11-121-10/+40
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /image/restore/basic REST API parametersRoberto Hueso Gómez2019-11-121-10/+38
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /image/create/incremental REST API parametersRoberto Hueso Gómez2019-11-121-7/+32
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /image/create/basic REST API parametersRoberto Hueso Gómez2019-11-121-34/+84
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /image/setup REST API parametersRoberto Hueso Gómez2019-11-121-15/+62
| | | | This patch ensures that all required parameters are sent in the request.
* #839: Do not check partition type when obtaining computer configuration to ↵Ramón M. Gómez2019-11-111-15/+8
| | | | hide/unhide NTFS partitions.
* #915 Validate POST /image/restore REST API parametersRoberto Hueso Gómez2019-11-061-8/+28
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /image/create REST API parametersRoberto Hueso Gómez2019-11-061-7/+27
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /software REST API parametersRoberto Hueso Gómez2019-11-061-2/+11
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /hardware REST API parametersRoberto Hueso Gómez2019-11-061-0/+3
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /refresh REST API parametersRoberto Hueso Gómez2019-11-061-0/+3
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /stop REST API parametersRoberto Hueso Gómez2019-11-061-0/+3
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /reboot REST API parametersRoberto Hueso Gómez2019-11-061-0/+3
| | | | This patch ensures that all required parameters are sent in the request.
* #915 Validate POST /poweroff REST API parametersRoberto Hueso Gómez2019-11-061-0/+3
| | | | This patch ensures that all required parameters are sent in the request.