summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* #559 fix out of bound array accessJavier Sánchez Parra2019-08-281-1/+1
| | | | | | | | This patch change the size of the array ptrPar from 6 to 7. cppcheck says: [sources/ogAdmServer.cpp:598]: (error) Array 'ptrCfg[6]' accessed at index 6, which is out of bounds.
* #915 check ogAdmServer binary existence when running pythong testsJavier Sánchez Parra2019-08-281-0/+4
| | | | | | | | | | | Currently, if you try to run the python test without the ogAdmServer binary, it will throw an exception. This patch adds a check to ensure the existence of the ogAdmServer binary at the beginning of the script. # python3 run-tests.py You need to build the ogAdmServer binary to run these tests :-)
* #915 add missing brackets to WOL API test jsonJavier Sánchez Parra2019-08-281-2/+2
| | | | | Without the brackets the call works (200 response) but the ogAdmServer does not send the WOL packets.
* #915 trim unknown command syslog error to the initial 32 bytesOpenGnSys Support Team2019-08-281-1/+1
| | | | | Aug 28 17:12:33 server ogAdmServer[10110]: 127.0.0.1:54640 POST /nonexistent HTTP/1.1^M Host ... Aug 28 17:12:33 server ogAdmServer[10110]: unknown command: nonexistent HTTP/1.1^M Host: loca ...
* #915 add syslog error when HTTP request processing failsOpenGnSys Support Team2019-08-281-4/+17
|
* #915 add og_server_internal_error()OpenGnSys Support Team2019-08-281-5/+12
| | | | This function sends a 500 HTTP error to client.
* #915 add syslog debugging for HTTP requestOpenGnSys Support Team2019-08-281-4/+4
| | | | Display initial 32 bytes of the HTTP request.
* #915 close connection to REST API if request is too longOpenGnSys Support Team2019-08-281-1/+8
| | | | If REST API request length is >= 4096 bytes, close the connection.
* #915 add OG_CLIENTS_MAX definitionOpenGnSys Support Team2019-08-281-2/+4
| | | | | This definition specifies the maximum number of clients, that is set up to 4096.
* #915 set maximum REST API response to 64 KbytesOpenGnSys Support Team2019-08-281-2/+4
| | | | | The existing 4 Kbytes might not be enough to store the results of the GET /clients request, extend it up to 64 Kbytes.
* #915 json_dump_callback() takes flags as a parameterOpenGnSys Support Team2019-08-281-2/+2
| | | | | Not as the buffer size, this leads to incorrectly printing the json output since this might set on the JSON_EMBED flag on libjansson >= 2.10
* #915 allow up to 4096 clients from REST APIOpenGnSys Support Team2019-08-281-2/+2
| | | | Raise maximum number of clients to 4096.
* #915 reply with HTTP 405 when the method is incorrectJavier Sánchez Parra2019-08-271-12/+25
| | | | | When a command/request exists but the method is not correct returns 405 error code.
* #915 internal error response if reply is too longOpenGnSys Support Team2019-08-271-4/+11
| | | | In case reply is too long, return 501 internal server error.
* Merge branch 'devel-browser-newlinks' into develRamón M. Gómez2019-08-200-0/+0
|\
| * #891 fix crash in wol commandOpenGnSys Support Team2019-08-201-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Irina reports a crash in the wol command on Ubuntu 18.04 and gcc 7.4.0: ==9542== Process terminating with default action of signal 6 (SIGABRT) ==9542== at 0x6C37E97: raise (raise.c:51) ==9542== by 0x6C39800: abort (abort.c:79) ==9542== by 0x6C82896: __libc_message (libc_fatal.c:181) ==9542== by 0x6D2DCD0: __fortify_fail_abort (fortify_fail.c:33) ==9542== by 0x6D2DC91: __stack_chk_fail (stack_chk_fail.c:29) ==9542== by 0x111DB1: WakeUp(int, char*, char*, char*) (ogAdmServer.cpp:1390) ==9542== by 0x11199F: Levanta(char**, char**, int, char*) (ogAdmServer.cpp:1251) ==9542== by 0x118372: og_cmd_wol(json_t*, og_msg_params*) (ogAdmServer.cpp:3580) ==9542== by 0x119B91: og_client_state_process_payload_rest(og_client*) (ogAdmServer.cpp:4030) ==9542== by 0x11A4E9: og_client_read_cb(ev_loop*, ev_io*, int) (ogAdmServer.cpp:4212) ==9542== by 0x5EA1D72: ev_invoke_pending (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) ==9542== by 0x5EA53DD: ev_run (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) sscanf() returns integers (32-bits) instead of array of 8-bits.
* | #891 fix crash in wol commandOpenGnSys Support Team2019-07-291-6/+6
|/ | | | | | | | | | | | | | | | | | | | Irina reports a crash in the wol command on Ubuntu 18.04 and gcc 7.4.0: ==9542== Process terminating with default action of signal 6 (SIGABRT) ==9542== at 0x6C37E97: raise (raise.c:51) ==9542== by 0x6C39800: abort (abort.c:79) ==9542== by 0x6C82896: __libc_message (libc_fatal.c:181) ==9542== by 0x6D2DCD0: __fortify_fail_abort (fortify_fail.c:33) ==9542== by 0x6D2DC91: __stack_chk_fail (stack_chk_fail.c:29) ==9542== by 0x111DB1: WakeUp(int, char*, char*, char*) (ogAdmServer.cpp:1390) ==9542== by 0x11199F: Levanta(char**, char**, int, char*) (ogAdmServer.cpp:1251) ==9542== by 0x118372: og_cmd_wol(json_t*, og_msg_params*) (ogAdmServer.cpp:3580) ==9542== by 0x119B91: og_client_state_process_payload_rest(og_client*) (ogAdmServer.cpp:4030) ==9542== by 0x11A4E9: og_client_read_cb(ev_loop*, ev_io*, int) (ogAdmServer.cpp:4212) ==9542== by 0x5EA1D72: ev_invoke_pending (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) ==9542== by 0x5EA53DD: ev_run (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) sscanf() returns integers (32-bits) instead of array of 8-bits.
* #915 adds tests for a non existent methodJavier Sánchez Parra2019-07-151-0/+30
| | | | | | | | | This test adds four new error test cases: 1. Non existent method with POST. 2. Non existent method with GET. 3. Non existent method with POST but with wrong API token. 4. Non existent method with POST but without json.
* #915 returns 401 when incorrect authentication happensJavier Sánchez Parra2019-07-151-1/+3
| | | | | | | | ogAdmServer REST API now meets the starndar RFC 7235 when incorrect auth happens. og_client_not_authorized() now sends "401 Unauthorized" and "WWW-Authenticate" instead of 404.
* #915 adds test for POST /software REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /hardware REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /refresh REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /stop REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /reboot REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /poweroff REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 tests correct command, /sessionJavier Sánchez Parra2019-07-151-1/+1
| | | | This should test /shell/run instead of /session
* #559 fixes memory leak in tomaConfiguracion()Javier Sánchez Parra2019-07-151-0/+2
| | | | Calls fclose() after fopen() to release memory.
* #915 Improve test output using unittest discoverJavier Sánchez Parra2019-07-057-2/+1
| | | | | | | | * Call the tests with python module unittest. In particular, the discover function. * Rename tests files to meet the default requirements of discover function.
* #915 add POST software command to REST API in ogAdmServerOpenGnSys Support Team2019-07-032-0/+31
| | | | | | | | | | | | | This patch implements the command "software" that fetches the software configuration from the clients. Request: POST /software {"clients" : [ "192.168.2.1", "192.168.2.2" ]} Reply: 200 OK This allows to refresh the software inventory from clients.
* #915 add POST hardware command to REST API in ogAdmServerOpenGnSys Support Team2019-07-032-0/+31
| | | | | | | | | | | | | This patch implements the command "hardware" that fetches the hardware configuration from the clients. Request: POST /hardware {"clients" : [ "192.168.2.1", "192.168.2.2" ]} Reply: 200 OK This allows to refresh the hardware inventory from clients.
* #915 Add API token to tests in ogAdmServer/tests/units/*Javier Sánchez Parra2019-06-246-12/+20
| | | | Add token parameter in REST API test infrastructure.
* #915 update installer to add APITOKEN= to ogAdmServer.cfgJavier Sánchez Parra2019-06-241-0/+1
| | | | | | | | This is going to be used to protect calls to ogAdmServer Example line for ogAdmServer.cfg: APITOKEN=9b5fddfc5d4d1daa74ffd7ce7c3c9925
* #915 add support for HTTP AuthorizationOpenGnSys Support Team2019-06-243-11/+35
| | | | Add APITOKEN= field to ogAdmServer.cfg to specify the REST API key.
* #915 Remove unnecessary return in ogAdmServer/tests/run-tests.pyJavier Sánchez Parra2019-06-121-4/+0
| | | | No need to explicit return call, remove it.
* #896 Fix memory leak in wake_up_broadcast()Javier Sánchez Parra2019-06-121-1/+1
| | | | call freeifaddrs() after getifaddrs() to release memory.
* #915 add test for POST /session REST APIJavier Sánchez Parra2019-05-311-0/+20
|
* #915 add test for POST /shell/output REST APIJavier Sánchez Parra2019-05-311-0/+18
|
* #915 add test for POST /shell/run REST APIJavier Sánchez Parra2019-05-311-0/+18
|
* #915 add test for POST /wol REST APIJavier Sánchez Parra2019-05-311-0/+20
|
* #915 add test for POST /clients REST APIJavier Sánchez Parra2019-05-311-0/+19
|
* #915 add test for GET /clients REST APIJavier Sánchez Parra2019-05-311-0/+18
|
* #915 add unit test infrastructure for REST APIJavier Sánchez Parra2019-05-312-0/+49
| | | | | | | | | This python script creates a database and starts ogAdmServer to run the tests. This requires root to be launched: # ./run-tests.py From the 'tests' folder.
* #915 validate message length based on announced Content-Length fieldOpenGnSys Support Team2019-05-311-10/+14
| | | | | Otherwise, TCP segmentation leads to handle an incomplete payload, this problems manifests with errors when parsing the json body.
* #915 remove Actualizar(), Purgar(), Reiniciar() and IniciarSesion()OpenGnSys Support Team2019-05-301-86/+0
| | | | | | | | | The new REST API obsoletes the following commands: - Actualizar() has been replaced by POST /refresh. - Purgar() has been replaced by POST /stop. - Reiniciar() has been replaced by POST /reboot. - IniciarSesion() has been replaced by POST /session.
* #915 add POST refresh command to REST API in ogAdmServerOpenGnSys Support Team2019-05-302-0/+30
| | | | | | | | | | | | | Forces client to fetch and run any pending command from the server, reload its local configuration file and re-start its selection menu. curl -X POST http://127.0.0.1:8888/refresh -d @refresh.json Request POST /refresh {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add POST stop command to REST API in ogAdmServerOpenGnSys Support Team2019-05-303-0/+31
| | | | | | | | | | | | Stop the menu selection on client (through POST method): curl -X POST http://127.0.0.1:8888/stop -d @stop.json Request POST /stop {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add POST reboot command to REST API in ogAdmServerOpenGnSys Support Team2019-05-303-0/+31
| | | | | | | | | | | | Reboot a client (through POST method): curl -X POST http://127.0.0.1:8888/reboot -d @reboot.json Request POST /reboot {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add POST poweroff command to REST API in ogAdmServerOpenGnSys Support Team2019-05-303-0/+31
| | | | | | | | | | | | Power off a client (through POST method): curl -X POST http://127.0.0.1:8888/poweroff -d @poweroff.json Request POST /poweroff {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add og_cmd_legacy_send()OpenGnSys Support Team2019-05-291-4/+5
| | | | Add function to send legacy command to clients.
* #915 remove Sondeo(), respuestaSondeo(), ConsolaRemota(), Arrancar() and ↵OpenGnSys Support Team2019-05-271-199/+0
| | | | | | | | | | | | EcoConsola() The new REST API obsoletes the following commands: - Sondeo() has been replaced by GET /clients. - respuestaSondeo() has been replaced by POST /clients. - ConsolaRemota() has been replaced by POST /shell/run. - EcoConsola() has been replaced by POST /shell/output. - Arrancar() has been replaced by POST /wol.