summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'devel-browser-newlinks' into develRamón M. Gómez2019-08-200-0/+0
|\
| * #891 fix crash in wol commandOpenGnSys Support Team2019-08-201-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Irina reports a crash in the wol command on Ubuntu 18.04 and gcc 7.4.0: ==9542== Process terminating with default action of signal 6 (SIGABRT) ==9542== at 0x6C37E97: raise (raise.c:51) ==9542== by 0x6C39800: abort (abort.c:79) ==9542== by 0x6C82896: __libc_message (libc_fatal.c:181) ==9542== by 0x6D2DCD0: __fortify_fail_abort (fortify_fail.c:33) ==9542== by 0x6D2DC91: __stack_chk_fail (stack_chk_fail.c:29) ==9542== by 0x111DB1: WakeUp(int, char*, char*, char*) (ogAdmServer.cpp:1390) ==9542== by 0x11199F: Levanta(char**, char**, int, char*) (ogAdmServer.cpp:1251) ==9542== by 0x118372: og_cmd_wol(json_t*, og_msg_params*) (ogAdmServer.cpp:3580) ==9542== by 0x119B91: og_client_state_process_payload_rest(og_client*) (ogAdmServer.cpp:4030) ==9542== by 0x11A4E9: og_client_read_cb(ev_loop*, ev_io*, int) (ogAdmServer.cpp:4212) ==9542== by 0x5EA1D72: ev_invoke_pending (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) ==9542== by 0x5EA53DD: ev_run (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) sscanf() returns integers (32-bits) instead of array of 8-bits.
* | #891 fix crash in wol commandOpenGnSys Support Team2019-07-291-6/+6
|/ | | | | | | | | | | | | | | | | | | | Irina reports a crash in the wol command on Ubuntu 18.04 and gcc 7.4.0: ==9542== Process terminating with default action of signal 6 (SIGABRT) ==9542== at 0x6C37E97: raise (raise.c:51) ==9542== by 0x6C39800: abort (abort.c:79) ==9542== by 0x6C82896: __libc_message (libc_fatal.c:181) ==9542== by 0x6D2DCD0: __fortify_fail_abort (fortify_fail.c:33) ==9542== by 0x6D2DC91: __stack_chk_fail (stack_chk_fail.c:29) ==9542== by 0x111DB1: WakeUp(int, char*, char*, char*) (ogAdmServer.cpp:1390) ==9542== by 0x11199F: Levanta(char**, char**, int, char*) (ogAdmServer.cpp:1251) ==9542== by 0x118372: og_cmd_wol(json_t*, og_msg_params*) (ogAdmServer.cpp:3580) ==9542== by 0x119B91: og_client_state_process_payload_rest(og_client*) (ogAdmServer.cpp:4030) ==9542== by 0x11A4E9: og_client_read_cb(ev_loop*, ev_io*, int) (ogAdmServer.cpp:4212) ==9542== by 0x5EA1D72: ev_invoke_pending (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) ==9542== by 0x5EA53DD: ev_run (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) sscanf() returns integers (32-bits) instead of array of 8-bits.
* #915 adds tests for a non existent methodJavier Sánchez Parra2019-07-151-0/+30
| | | | | | | | | This test adds four new error test cases: 1. Non existent method with POST. 2. Non existent method with GET. 3. Non existent method with POST but with wrong API token. 4. Non existent method with POST but without json.
* #915 returns 401 when incorrect authentication happensJavier Sánchez Parra2019-07-151-1/+3
| | | | | | | | ogAdmServer REST API now meets the starndar RFC 7235 when incorrect auth happens. og_client_not_authorized() now sends "401 Unauthorized" and "WWW-Authenticate" instead of 404.
* #915 adds test for POST /software REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /hardware REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /refresh REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /stop REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /reboot REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 adds test for POST /poweroff REST APIJavier Sánchez Parra2019-07-151-0/+20
| | | | | | | This test covers two two scenarios: 1. Correct usage. 2. Incorrect usage, use this command with GET (this returns http 405).
* #915 tests correct command, /sessionJavier Sánchez Parra2019-07-151-1/+1
| | | | This should test /shell/run instead of /session
* #559 fixes memory leak in tomaConfiguracion()Javier Sánchez Parra2019-07-151-0/+2
| | | | Calls fclose() after fopen() to release memory.
* #915 Improve test output using unittest discoverJavier Sánchez Parra2019-07-057-2/+1
| | | | | | | | * Call the tests with python module unittest. In particular, the discover function. * Rename tests files to meet the default requirements of discover function.
* #915 add POST software command to REST API in ogAdmServerOpenGnSys Support Team2019-07-032-0/+31
| | | | | | | | | | | | | This patch implements the command "software" that fetches the software configuration from the clients. Request: POST /software {"clients" : [ "192.168.2.1", "192.168.2.2" ]} Reply: 200 OK This allows to refresh the software inventory from clients.
* #915 add POST hardware command to REST API in ogAdmServerOpenGnSys Support Team2019-07-032-0/+31
| | | | | | | | | | | | | This patch implements the command "hardware" that fetches the hardware configuration from the clients. Request: POST /hardware {"clients" : [ "192.168.2.1", "192.168.2.2" ]} Reply: 200 OK This allows to refresh the hardware inventory from clients.
* #915 Add API token to tests in ogAdmServer/tests/units/*Javier Sánchez Parra2019-06-246-12/+20
| | | | Add token parameter in REST API test infrastructure.
* #915 update installer to add APITOKEN= to ogAdmServer.cfgJavier Sánchez Parra2019-06-241-0/+1
| | | | | | | | This is going to be used to protect calls to ogAdmServer Example line for ogAdmServer.cfg: APITOKEN=9b5fddfc5d4d1daa74ffd7ce7c3c9925
* #915 add support for HTTP AuthorizationOpenGnSys Support Team2019-06-243-11/+35
| | | | Add APITOKEN= field to ogAdmServer.cfg to specify the REST API key.
* #915 Remove unnecessary return in ogAdmServer/tests/run-tests.pyJavier Sánchez Parra2019-06-121-4/+0
| | | | No need to explicit return call, remove it.
* #896 Fix memory leak in wake_up_broadcast()Javier Sánchez Parra2019-06-121-1/+1
| | | | call freeifaddrs() after getifaddrs() to release memory.
* #915 add test for POST /session REST APIJavier Sánchez Parra2019-05-311-0/+20
|
* #915 add test for POST /shell/output REST APIJavier Sánchez Parra2019-05-311-0/+18
|
* #915 add test for POST /shell/run REST APIJavier Sánchez Parra2019-05-311-0/+18
|
* #915 add test for POST /wol REST APIJavier Sánchez Parra2019-05-311-0/+20
|
* #915 add test for POST /clients REST APIJavier Sánchez Parra2019-05-311-0/+19
|
* #915 add test for GET /clients REST APIJavier Sánchez Parra2019-05-311-0/+18
|
* #915 add unit test infrastructure for REST APIJavier Sánchez Parra2019-05-312-0/+49
| | | | | | | | | This python script creates a database and starts ogAdmServer to run the tests. This requires root to be launched: # ./run-tests.py From the 'tests' folder.
* #915 validate message length based on announced Content-Length fieldOpenGnSys Support Team2019-05-311-10/+14
| | | | | Otherwise, TCP segmentation leads to handle an incomplete payload, this problems manifests with errors when parsing the json body.
* #915 remove Actualizar(), Purgar(), Reiniciar() and IniciarSesion()OpenGnSys Support Team2019-05-301-86/+0
| | | | | | | | | The new REST API obsoletes the following commands: - Actualizar() has been replaced by POST /refresh. - Purgar() has been replaced by POST /stop. - Reiniciar() has been replaced by POST /reboot. - IniciarSesion() has been replaced by POST /session.
* #915 add POST refresh command to REST API in ogAdmServerOpenGnSys Support Team2019-05-302-0/+30
| | | | | | | | | | | | | Forces client to fetch and run any pending command from the server, reload its local configuration file and re-start its selection menu. curl -X POST http://127.0.0.1:8888/refresh -d @refresh.json Request POST /refresh {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add POST stop command to REST API in ogAdmServerOpenGnSys Support Team2019-05-303-0/+31
| | | | | | | | | | | | Stop the menu selection on client (through POST method): curl -X POST http://127.0.0.1:8888/stop -d @stop.json Request POST /stop {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add POST reboot command to REST API in ogAdmServerOpenGnSys Support Team2019-05-303-0/+31
| | | | | | | | | | | | Reboot a client (through POST method): curl -X POST http://127.0.0.1:8888/reboot -d @reboot.json Request POST /reboot {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add POST poweroff command to REST API in ogAdmServerOpenGnSys Support Team2019-05-303-0/+31
| | | | | | | | | | | | Power off a client (through POST method): curl -X POST http://127.0.0.1:8888/poweroff -d @poweroff.json Request POST /poweroff {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add og_cmd_legacy_send()OpenGnSys Support Team2019-05-291-4/+5
| | | | Add function to send legacy command to clients.
* #915 remove Sondeo(), respuestaSondeo(), ConsolaRemota(), Arrancar() and ↵OpenGnSys Support Team2019-05-271-199/+0
| | | | | | | | | | | | EcoConsola() The new REST API obsoletes the following commands: - Sondeo() has been replaced by GET /clients. - respuestaSondeo() has been replaced by POST /clients. - ConsolaRemota() has been replaced by POST /shell/run. - EcoConsola() has been replaced by POST /shell/output. - Arrancar() has been replaced by POST /wol.
* #915 add POST session command to REST API in ogAdmServerOpenGnSys Support Team2019-05-273-0/+80
| | | | | | | | | | | | Start a session on client (through POST method): curl -X POST http://127.0.0.1:8888/session -d @session.json Request POST /session {"clients": [ "192.168.2.1" ] } Reply: 200 OK
* #915 add POST shell/output command to REST API in ogAdmServerOpenGnSys Support Team2019-05-273-0/+95
| | | | | | | | | | | | | Fetching result from run command on client (through GET method): curl -X POST http://127.0.0.1:8888/shell/output -d @post_shell_output.json Request POST /shell/output {"clients": [ "192.168.2.1" ] } Reply: 200 OK {"clients": [ { "addr" : "192.168.2.1", "output" : "..." } ] }
* #915 add run command to REST API in ogAdmServerOpenGnSys Support Team2019-05-273-0/+77
| | | | | | | | | | | | Run command on client (through POST method): curl -X POST http://127.0.0.1:8888/shell/run -d @post_run.json Request POST /shell/run {"clients": [ "192.168.2.1", "192.168.2.2" ], "run" : "ls" } Reply: 200 OK
* #915 add wol command to REST API in ogAdmServerOpenGnSys Support Team2019-05-273-0/+110
| | | | | | | | | | Send Wake-On-Lan to clients (through POST method): Request: curl -X POST http://127.0.0.1:8888/wol { "type" : "unicast", "clients" : [ { "addr" : "192.168.2.1", "mac" : "00AABBCCDD01" } ] } Reply: 200 OK
* #915 Pass array of addresses to WakeUp()OpenGnSys Support Team2019-05-272-10/+17
| | | | To reuse this function to the REST API.
* #915 add clients command to REST API in ogAdmServerOpenGnSys Support Team2019-05-273-7/+90
| | | | | | | | | | | | Request for existing clients: curl -X GET http://127.0.0.1:8888/clients Request: GET /clients Reply: 200 OK {"clients": [ { "addr" : "192.168.2.1", "state" : "OPG" }, { "addr" : "192.168.2.2", "state" : "OFF" }]}
* #915 add initial REST API for ogAdmServerOpenGnSys Support Team2019-05-274-5/+181
| | | | | | | | | | | | | | | | | | | | | Add REST API for ogAdmServer, this API is exposed through port 8888 on the system that runs the ogAdmServer. The body of the HTTP message is expressed in JSON format. This patch implements the command "clients" that maps to the existing legacy "Sondeo" command, that is used by the web interface to poll refresh the client state. This patch also includes an initial test infrastructure using 'curl' to send commands to the new REST API. Request: POST /clients {"clients" : [ "192.168.2.1", "192.168.2.2" ]} Reply: 200 OK This allows to refresh the status of the list of clients.
* #915 add og_msg_alloc() and og_msg_free()OpenGnSys Support Team2019-05-271-9/+25
| | | | Add function to allocate and release the legacy message format.
* #915 add og_send_cmd()OpenGnSys Support Team2019-05-271-13/+25
| | | | | | Add new function to check and send commands to the clients. This new function takes an array of IP addresses (string) and send commands to the clients.
* #915 add og_socket_server_init()OpenGnSys Support Team2019-05-271-18/+28
| | | | Move code to create a socket into a function.
* #915 add og_client_state_process_payload()OpenGnSys Support Team2019-05-271-20/+31
| | | | Move code that handles the message payload into function.
* #915 add og_client_state_recv_hdr()OpenGnSys Support Team2019-05-271-23/+35
| | | | Move code that handles the receiving header state into function.
* #898 Remove unused encryption and decryption routinesOpenGnSys Support Team2019-02-061-1/+1
| | | | Remove dead code to encrypt and decrypt the message.
* #897 Do not use socket type in ogAdmServerOpenGnSys Support Team2019-02-062-6/+6
| | | | No need for an extra type, socket descriptors are always integer.