From 54ecdbbdf149990456be9b71d130c4f178a5c2ec Mon Sep 17 00:00:00 2001 From: Roberto Hueso Gómez Date: Tue, 5 Nov 2019 10:31:16 +0100 Subject: #915 Validate POST /clients parameters This patch adds og_msg_params_validate function as well as some flags that can be used to validate parameters of a REST API request. This patch ensures that all required parameters are sent in the request. --- sources/ogAdmServer.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sources/ogAdmServer.cpp b/sources/ogAdmServer.cpp index ab8e5f5..f275abe 100644 --- a/sources/ogAdmServer.cpp +++ b/sources/ogAdmServer.cpp @@ -3289,8 +3289,17 @@ struct og_msg_params { const char *cache_size; struct og_partition partition_setup[OG_PARTITION_MAX]; struct og_sync_params sync_setup; + uint64_t flags; }; +#define OG_REST_PARAM_ADDR (1UL << 0) + +static bool og_msg_params_validate(const struct og_msg_params *params, + const uint64_t flags) +{ + return (params->flags & flags) == flags; +} + static int og_json_parse_clients(json_t *element, struct og_msg_params *params) { unsigned int i; @@ -3307,6 +3316,9 @@ static int og_json_parse_clients(json_t *element, struct og_msg_params *params) params->ips_array[params->ips_array_len++] = json_string_value(k); } + + params->flags |= OG_REST_PARAM_ADDR; + return 0; } @@ -3440,6 +3452,9 @@ static int og_cmd_post_clients(json_t *element, struct og_msg_params *params) break; } + if (!og_msg_params_validate(params, OG_REST_PARAM_ADDR)) + return -1; + return og_cmd_legacy_send(params, "Sondeo", CLIENTE_APAGADO); } -- cgit v1.2.3-18-g5258