fix connect error path

Use syslog() and do not check for EINPROGRESS on the second connect() call.

1 files changed, 5 insertions, 6 deletions

diff --git a/src/main.c b/src/main.c
index c334049..a246bc6 100644
--- a/src/main.c
+++ b/src/main.c
@@ -303,11 +303,9 @@ static void tip_client_connect_cb(struct ev_loop *loop, struct ev_io *io, int ev
 	len = sizeof(cli->addr);
 	ret = connect(cli->io.fd, (struct sockaddr *)&cli->addr, len);
 	if (ret < 0) {
-		if (errno != EINPROGRESS) {
-			perror("connect");
-			tip_client_error(cli);
-			return;
-		}
+		syslog(LOG_ERR, "failed to connect to server to fetch %s", filename);
+		tip_client_error(cli);
+		return;
 	}
 
 	if (cli->state == TIP_CLIENT_NOTIFY_REDIRECT)
@@ -362,7 +360,8 @@ static int tip_client_connect(const char *addr)
 	len = sizeof(cli->addr);
 	ret = connect(remote_fd, (struct sockaddr *)&cli->addr, len);
 	if (ret < 0 && errno != EINPROGRESS) {
-		perror("connect");
+		syslog(LOG_ERR, "failed to connect to server to fetch %s", filename);
+		tip_client_error(cli);
 		return ret;
 	}